Skip to content

refactor: remove unused Nip05Obj inner class #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tcheeric merged 1 commit into from
Aug 22, 2025
Merged

refactor: remove unused Nip05Obj inner class #411

tcheeric merged 1 commit into from
Aug 22, 2025

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Aug 22, 2025

Why now?

Remove an unused inner class to simplify the validator implementation.
Related issue: #000

What changed?

  • drop Nip05Obj inner class from Nip05Validator

BREAKING

Review focus

  • Ensure no lingering references to the removed class.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • rg Nip05Obj -n
  • mvn -q verify (fails: Could not find a valid Docker environment)

https://chatgpt.com/codex/tasks/task_b_68a812df6fb48331bc3f79c8a2ded338

@tcheeric tcheeric requested a review from Copilot August 22, 2025 06:56
Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unused inner class Nip05Obj from the Nip05Validator class to simplify the codebase and eliminate dead code.

  • Removed the Nip05Obj inner class that was not being used anywhere in the validator implementation

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tcheeric tcheeric merged commit b6b81e7 into develop Aug 22, 2025
4 checks passed
@tcheeric tcheeric deleted the codex/remove-nip05obj-inner-class branch August 22, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcheeric @codecov-commenter