test: add validation tests for event implementations #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands test coverage for Nostr event validation by adding comprehensive validation tests for 9 different event implementation types. The tests verify that events correctly validate their kind values, required tags, and other constraints according to Nostr protocol specifications.
- Adds validation tests for addressable, ephemeral, replaceable, and various message event types
- Tests both successful validation scenarios and failure cases with invalid kinds or missing required tags
- Includes clear plain-English comments explaining the validation rules being tested
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AddressableEventValidateTest.java | Tests kind validation for addressable events (30000-39999 range) |
| ChannelMessageEventValidateTest.java | Validates channel message events require root event tags |
| DeletionEventValidateTest.java | Tests deletion events require event/author and kind tags |
| DirectMessageEventValidateTest.java | Validates direct messages require recipient public key tags |
| EphemeralEventValidateTest.java | Tests ephemeral event kind range validation (20000-29999) |
| HideMessageEventValidateTest.java | Validates hide message events require event tags |
| MuteUserEventValidateTest.java | Tests mute user events require pubkey tags |
| ReactionEventValidateTest.java | Validates reaction events require event tags |
| ReplaceableEventValidateTest.java | Tests replaceable event kind validation including special cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment)Network Access
https://chatgpt.com/codex/tasks/task_b_68a747cfe1c88331931b320d049c1664