Validate event fields with null checks #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances event validation by adding null checks for required fields before hex validation and includes comprehensive unit tests to verify the behavior.
- Adds null validation for
id,pubkey, andsigfields usingObjects.requireNonNull()with descriptive error messages - Implements unit tests to verify that
NullPointerExceptionis thrown with appropriate messages when required fields are missing - Ensures validation fails fast with clear error messages when mandatory fields are null
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nostr-java-event/src/main/java/nostr/event/impl/GenericEvent.java | Adds null checks with custom error messages before hex validation for id, pubkey, and signature fields |
| nostr-java-event/src/test/java/nostr/event/impl/GenericEventValidateTest.java | Implements comprehensive unit tests to verify null field validation behavior and error messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
id,pubkey, andsigbefore hex validationTesting
mvn -q verify(fails: Could not find a valid Docker environment for Testcontainers)Network Access
https://chatgpt.com/codex/tasks/task_b_68991201d8cc8331b16003a23cabde2b