refactor: centralize websocket retry settings #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Centralizes WebSocket retry configuration by creating a reusable @NostrRetryable annotation to eliminate code duplication and improve maintainability.
- Created a new meta-annotation that encapsulates retry configuration for WebSocket operations
- Replaced duplicate
@Retryableannotations inSpringWebSocketClientwith the centralized annotation - Extracted retry settings as constants for better configurability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| NostrRetryable.java | New meta-annotation that encapsulates common retry configuration with constants |
| SpringWebSocketClient.java | Simplified by replacing duplicate retry annotations with the new centralized annotation |
Comment on lines
+17
to
+18
| @Retryable(value = IOException.class, maxAttempts = NostrRetryable.MAX_ATTEMPTS, | ||
| backoff = @Backoff(delay = NostrRetryable.DELAY, multiplier = NostrRetryable.MULTIPLIER)) |
There was a problem hiding this comment.
Using the annotation's own constants in its definition creates a circular dependency that may not work as expected. Consider using literal values directly in the @retryable annotation instead.
Suggested change
| @Retryable(value = IOException.class, maxAttempts = NostrRetryable.MAX_ATTEMPTS, | |
| backoff = @Backoff(delay = NostrRetryable.DELAY, multiplier = NostrRetryable.MULTIPLIER)) | |
| @Retryable(value = IOException.class, maxAttempts = 3, | |
| backoff = @Backoff(delay = 500L, multiplier = 2.0)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@NostrRetryableannotation encapsulating retry configurationSpringWebSocketClientsend methods to remove duplicate settingsTesting
mvn -q verify(fails: Previous attempts to find a Docker environment failed. Will not retry.)https://chatgpt.com/codex/tasks/task_b_688f63abc1488331be271d8ffead17bc