Refactor Constants Kind and Tag #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Constants class by converting the inner interfaces Kind and Tag to final classes with public static final fields, improving type safety and preventing implementation. It also adds comprehensive regression tests to verify constant values and serialization behavior.
- Convert
Constants.KindandConstants.Tagfrom interfaces to final classes - Add private constructors to prevent instantiation of the constant classes
- Include regression tests for constant values and JSON serialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nostr-java-api/src/main/java/nostr/config/Constants.java | Refactors inner interfaces to final classes with static final fields and private constructors |
| nostr-java-api/src/test/java/nostr/api/unit/ConstantsTest.java | Adds new test class to verify constant values and serialization behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Constants.KindandConstants.Tagfrom interfaces to final classes withpublic static finalfieldsTesting
mvn -q verify && echo DONEhttps://chatgpt.com/codex/tasks/task_b_688a862ac6948331b777c036f6054b21