[immutable-arraybuffer] ArrayBuffer.prototype.transferToImmutable#4542
Open
[immutable-arraybuffer] ArrayBuffer.prototype.transferToImmutable#4542
Conversation
67 tasks
397f433 to
1178b37
Compare
54d4221 to
973e13e
Compare
Ms2ger
requested changes
Aug 22, 2025
Comment on lines
+42
to
+47
| function repr(value) { | ||
| if (typeof value === "string") return JSON.stringify(value); | ||
| if (typeof value === "bigint") return String(value) + "n"; | ||
| if (!value && 1/value === -Infinity) return "-0"; | ||
| return String(value); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this belongs here
| return String(value); | ||
| } | ||
|
|
||
| var goodLengths = [ |
Contributor
There was a problem hiding this comment.
I'm willing to accept this test, but I think it would be nicer if we could have a generic helper function that runs through a set of interesting ToIndex arguments; this isn't the only API that could be tested in this way.
| ]; | ||
|
|
||
| for (var i = 0; i < sourceMakers.length; i++) { | ||
| var name = sourceMakers[i].name; |
Contributor
There was a problem hiding this comment.
This doesn't take into account that sourceMakers[i] might be undefined.
|
|
||
| for (var i = 0; i < sourceMakers.length; i++) { | ||
| var name = sourceMakers[i].name; | ||
| var newLength = byteLength + i + 1; |
Contributor
There was a problem hiding this comment.
Calculating the argument based on the index in the array seems a recipe for confusion
| ]; | ||
|
|
||
| for (var i = 0; i < sourceMakers.length; i++) { | ||
| var name = sourceMakers[i].name; |
Comment on lines
+56
to
+60
| for ( | ||
| var newLength = undefined; | ||
| (newLength || 0) < byteLength; | ||
| newLength = newLength === undefined ? 0 : newLength + 1 | ||
| ) { |
Contributor
There was a problem hiding this comment.
This is very convoluted, probably too much so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4509