Conversation
34 tasks
ptomato
approved these changes
Oct 15, 2024
Contributor
ptomato
left a comment
There was a problem hiding this comment.
LGTM but with s/assert.equal/assert.sameValue/g (or in the case of assert.equal(..., boolean) consider replacing with assert())
Member
Author
|
Thanks, updated (kept the explicit comparisons because i prefer them over implicit ones) |
Contributor
|
I think that these tests are missing a feature flag (for example, |
Contributor
Thanks, but would you mind opening an issue (or a new PR if you have the time?) As a comment on a merged PR, it is likely to be missed. |
Member
Author
|
whoops, thanks. i'll add one in a PR right now. |
ljharb
added a commit
that referenced
this pull request
Oct 17, 2024
Member
Author
|
→ #4271 |
ptomato
pushed a commit
that referenced
this pull request
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-is-error#7