Add test with non-IANA time zone names#4005
Merged
Conversation
Contributor
Author
|
Non-IANA time zone ids should be rejected to avoid bug reports like: https://bugzilla.mozilla.org/show_bug.cgi?id=1879554. |
ptomato
approved these changes
Feb 9, 2024
Contributor
ptomato
left a comment
There was a problem hiding this comment.
Makes sense. Would you like to write the same test additionally for new Temporal.TimeZone() and Temporal.TimeZone.from()?
Contributor
Author
Sure. I've pushed 826de80 to cover |
Ms2ger
approved these changes
Feb 12, 2024
Time zone identifiers supported by ICU, but which aren't valid IANA identifiers.
Time zone identifiers supported by ICU, but which aren't valid IANA identifiers. Implementations not supporting ECMA-402 are theoretically allowed to support these identifiers, so the tests have to go into the "intl402" directory.
826de80 to
cd13992
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time zone identifiers supported by ICU, but which aren't valid IANA identifiers.