Don't polyfill Temporal and Intl onto the global object#851
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 17 17
Lines 4840 4840
Branches 751 751
=======================================
Hits 4470 4470
Misses 363 363
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljharb
approved these changes
Aug 26, 2020
Member
ljharb
left a comment
There was a problem hiding this comment.
usually i use the term "shim" for a self-installing polyfill ¯\_(ツ)_/¯
In order to avoid breaking the web when Temporal is shipped, don't polyfill onto the global object. We don't want any `if (typeof Temporal === undefined)` checks in the wild until browsers actually start shipping Temporal. We do still need it on the global object for the browser playground and the test262 tests, so we now have two separate entry points to the library: index.mjs and shim.mjs. Closes: #778
2c5ec07 to
46aad33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid breaking the web when Temporal is shipped, don't
polyfill onto the global object. We don't want any
if (typeof Temporal === undefined)checks in the wild until browsers actually startshipping Temporal.
We do still need it on the global object for the browser playground and
the test262 tests, so we now have two separate entry points to the
library: index.mjs and polyfill.mjs.
Closes: #778