Conversation
|
The rendered spec for this PR is available at https://tc39.es/proposal-import-bytes/pr/20. |
Member
Author
|
Seems I can't add reviewers to this PR so I'll tag @guybedford @eemeli @jasnell @nicolo-ribaudo 😃 |
jasnell
approved these changes
Sep 8, 2025
guybedford
approved these changes
Sep 8, 2025
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
In line 128 we should now create a Uint8Array, right?
Contributor
|
@nicolo-ribaudo yes, I've also posted #21 for this. I think it makes sense as a separate PR. |
nicolo-ribaudo
approved these changes
Sep 8, 2025
eemeli
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #12 we changed the type from
buffertobytesagain and the output was changed from ArrayBuffer to Uint8Array, but the spec was not updated.This PR updates the spec to match the readme.