Explicit member names should use ComputedPropertyName syntax#71
Merged
michaelficarra merged 1 commit intomainfrom Jan 7, 2026
Merged
Explicit member names should use ComputedPropertyName syntax#71michaelficarra merged 1 commit intomainfrom
michaelficarra merged 1 commit intomainfrom
Conversation
10089e3 to
5df3a76
Compare
ljharb
reviewed
Jan 7, 2026
| protocol Iterable { | ||
| requires [Symbol.iterator]; | ||
|
|
||
| forEach(f) { |
Member
There was a problem hiding this comment.
Nope. forEach asks it to install a symbol by default. #47 would allow somebody to also get "forEach" installed via a per-class opt-in.
Member
There was a problem hiding this comment.
ah ok, if that's the intention then this is fine :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in various places, including #48