Normative: Propagate phase in re-exported deferred imports#79
Open
nicolo-ribaudo wants to merge 1 commit intotc39:mainfrom
Open
Normative: Propagate phase in re-exported deferred imports#79nicolo-ribaudo wants to merge 1 commit intotc39:mainfrom
nicolo-ribaudo wants to merge 1 commit intotc39:mainfrom
Conversation
caiolima
approved these changes
Mar 2, 2026
caiolima
left a comment
There was a problem hiding this comment.
I just left a nit comment, otherwise it LGTM.
This was referenced Mar 2, 2026
95d2625 to
b067d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tc39/ecma262#3715 indirectly changed this code:
to export a non-deferred namespace rather than a deferred one.
This PR restores the intended behavior, by propagating the phase appropriately.