Modify semantics to support auto-inserted parens#82
Conversation
|
Thanks for this patch! Will review soon (sorry for my delay). |
littledan
left a comment
There was a problem hiding this comment.
Seems like, in all cases, the receiver when the decorator is applied to the descriptor is undefined (before and after the patch). Also seems like we are inserting the parens in the parenthized expression case. Everyone good with these decisions? If so, LGTM
|
It would be nice if the syntax definition could be refactored to be closer to The way I understand this approach is not that it "adds parens for you", but that what's in the parens is just the optional contents of the argument list. The way it's phrased in the grammar still sounds like |
|
@Kovensky I don't quite follow. With this patch, |
|
Oh, no, I think this is the right semantics; it's just that, possibly because of the grammar production names, it feels like a monkey patch to the spec. The suggestion is just to refactor the grammar productions so the parens are seen as an optional argument list instead of a "call-like" expression. |
|
Unfortunately, we can't just use the |
Fixes #81