Skip to content

Normative: Improve branding for descriptors for decorators#63

Merged
littledan merged 1 commit intomasterfrom
branding
Feb 26, 2018
Merged

Normative: Improve branding for descriptors for decorators#63
littledan merged 1 commit intomasterfrom
branding

Conversation

@littledan
Copy link
Copy Markdown
Member

This patch adds @@toStringTag for the various kinds of descriptors
which are exposed to decorators. Rationale described in
#56 (comment)

Closes #56

@wycats
Copy link
Copy Markdown
Collaborator

wycats commented Feb 26, 2018

Can we add a non-normative comment that all built-in descriptors will have the @@ToStringTag ${kind} Descriptor?

This patch adds @@toStringTag for the various kinds of descriptors
which are exposed to decorators. Rationale described in
#56 (comment)

Closes #56
@littledan
Copy link
Copy Markdown
Member Author

@wycats Added such a note.

@littledan littledan merged commit 838b798 into master Feb 26, 2018
@littledan
Copy link
Copy Markdown
Member Author

Now that the parens are auto-inserted, we should revert this change. Anyone want to create a revert commit? (The Revert button doesn't do it automatically.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants