Normative: Wrap and unwrap Private Names to JS#125
Merged
Conversation
Internally, the specification makes use of Private Name values. Within JavaScript, these are always seen through wrapper objects. This patch makes it explicit where those wrapper objects are created and how they are accessed. In particular, each time a decorator sees a private name, it is seeing a distinct PrivateName object. Using fresh objects is analogous to what we do for decorator descriptors.
jridgewell
approved these changes
Jul 10, 2018
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, the specification makes use of Private Name values. Within
JavaScript, these are always seen through wrapper objects. This patch
makes it explicit where those wrapper objects are created and how they
are accessed. In particular, each time a decorator sees a private name,
it is seeing a distinct PrivateName object. Using fresh objects is
analogous to what we do for decorator descriptors.