Normative: avoid mostly-redundant await in async yield*#2819
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2818. See that PR for more context - this implements option 3 of the options listed there. Fixes #2813.
The main effect of this PR would be that if you had
then you would see printed
Promise.resolve(0)instead of, as currently,0. In other words, it would behave as if you'd writtenfor await (let x of inner)instead ofof outer().The other effect is a reduction in the number of promise ticks.
No difference (except in timing) would be observable without manually implementing
Symbol.asyncIteratorbecause async generators (and the async-from-sync wrapper, see step 6) alreadyawaitvalues before yielding or returning them.