Update psr/simple-cache version constraint#339
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates the PSR Simple Cache dependency constraint to support both version 1.0 and 3.0 branches, providing compatibility with newer versions of the PSR Simple Cache interface.
- Expanded version constraint from
^1.0to^1.0|^3.0for psr/simple-cache dependency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Could this be merged? I am getting conflicts with other dependencies (PHPUnit, Pest). |
|
Sure. I've not written any PHP in a long time but from what I can gather from https://www.php-fig.org/psr/psr-16/meta/#82-type-additions the interface is the same it's just got types so it shouldn't make any difference to this library |
|
Perfect, thanks for this. |
|
Could we get a new tagged release too? ;-) |
|
Strange. I am now just getting an error with this, which I'm sure I wasn't when using the PR: |
|
If anyone needs this, I have solved this by using https://github.com/cweagans/composer-patches and applying a patch to the Cache.php file. I have attached the patch file I have used – psr-cache.patch Below is the composer.json extra information: "extra": {
"patches": {
"imdbphp/imdbphp": [
{
"description": "Add typehints to IMDBPHP to support psr/simple-cache v3",
"url": "patches/imdbphp/imdbphp/psr-cache.patch"
}
]
}
}, |
No description provided.