Add Podcast Series & Music Video Support#333
Conversation
It should check for all valid IMDB title types because if not found it falls back to Movie always.
|
Hello @tboothman @jreklund. Would you be so kind as to merge this and tag a new version? |
|
I wouldn't bother to try to revive this version as it seems abandoned. If you want a working version with GraphQL check out my repo here And for the record this isn't a cry/try to lurk people to my github, i'm just trying to help to get a working version. |
|
Nice. But needs to be added to Packagist. |
|
Nope i'm not going to do that. My project is very simple so i don't think it needs all those bells and whistles. It ain't hard to download the source and extract it in your project is it? |
|
nice thumbs down but that doesn't really help? I might consider to add it to packagist but i'm not convinced jet fyi i have added my project to packagist |
|
Hello @tboothman @jreklund. Would you be so kind as to merge this and tag a new version? |
|
If i may to point you on errors in your proposal.. Line 40,56 and 100 in your proposal is wrong, there shouldn't be a trailing comma for the last parameter |
|
Thats just formatting preferences. It works either way. |
I agree that this works either way but is not best practice and may be removed in future php versions |
|
It depends on the targeted PHP version. Support for trailing comma in functions and methods was added in PHP 7.3. As this library is supposed to support legacy PHP versions (PHP 5.6) this will crash on < PHP 7.3. I use trailing commas daily on multiline functions/methods, but this library can't use them. https://php.watch/versions/7.3/func-call-trailing-comma Officially only PHP 8.1 and newer is supported by the PHP Foundation but some LTS versions of Linux provide support for older versions and some companies offer paid solutions for supporting end of life versions. |
|
Done |
|
Cheers. Could you tag a new version perhaps too? |
|
New version out. Took the time to updated the dev packages as well so they don't give off any warnings. Plenty of things broken (as usual) and some are fixed in PR's, but will have to leave that for another day. |
It should check for all valid IMDB title types because if the typ is not found it falls back to Movie, which might be wrong.