chat: create session files with 0600 owner-only permissions#366
Merged
Conversation
Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
tbckr
approved these changes
May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 75.80% 78.82% +3.01%
==========================================
Files 20 21 +1
Lines 1298 1143 -155
==========================================
- Hits 984 901 -83
+ Misses 226 154 -72
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355. Chat session files held conversation history but were created with 0644 (world-readable) via
os.Create, and existing files were reopened withdefaultFilePermissions = 0755; this commit changes the constant to 0600 and replacesos.Createwithos.OpenFile(..., O_WRONLY|O_CREATE|O_TRUNC, 0600)so sessions are owner-only on creation and on rewrite. Added a regression test inpkg/chat/filesystem_test.gothat assertsinfo.Mode().Perm() == 0600on both new and reopened session files.