Skip to content

Cherry pick DMG settings to 1.x#8334

Merged
FabianLars merged 4 commits intotauri-apps:1.xfrom
hjmallon:_hm/dmg-settings
Jun 17, 2024
Merged

Cherry pick DMG settings to 1.x#8334
FabianLars merged 4 commits intotauri-apps:1.xfrom
hjmallon:_hm/dmg-settings

Conversation

@hjmallon
Copy link
Copy Markdown

@hjmallon hjmallon commented Dec 4, 2023

What kind of change does this PR introduce?

Cherry pick from dev to 1.x

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@hjmallon hjmallon requested a review from a team as a code owner December 4, 2023 09:51
@hjmallon hjmallon changed the title Hm/dmg settings Cherry pick DMG settings to 1.x Dec 4, 2023
@hjmallon hjmallon mentioned this pull request Dec 4, 2023
Merged
13 tasks
@Hacksore Hacksore mentioned this pull request Dec 22, 2023
Closed
@FabianLars FabianLars mentioned this pull request Feb 28, 2024
Closed
@hjmallon hjmallon mentioned this pull request May 16, 2024
Closed
@FabianLars FabianLars self-assigned this May 18, 2024
@hjmallon hjmallon force-pushed the _hm/dmg-settings branch 2 times, most recently from abdc326 to bbbc73b Compare June 5, 2024 13:54
@hjmallon
Copy link
Copy Markdown
Author

hjmallon commented Jun 5, 2024

This is now rebased and I have signed all the cherry-picked commits

@hjmallon hjmallon force-pushed the _hm/dmg-settings branch from bbbc73b to da54ca8 Compare June 5, 2024 14:57
@hjmallon hjmallon mentioned this pull request Jun 5, 2024
Closed
@hjmallon hjmallon force-pushed the _hm/dmg-settings branch from da54ca8 to b4fc683 Compare June 5, 2024 15:14
FabianLars
FabianLars previously approved these changes Jun 10, 2024
View reviewed changes
@FabianLars FabianLars dismissed their stale review June 10, 2024 12:39

i meant to approve the ci checks, not the pr itself lol

FabianLars
FabianLars approved these changes Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why clippy is having a mental breakdown but i'll worry about that somewhere else, not in this PR.

Thanks again for the PR!

@FabianLars FabianLars merged commit 9243870 into tauri-apps:1.x Jun 17, 2024
@Lurrobert
Copy link
Copy Markdown

Lurrobert commented Jun 18, 2024 •
edited
Loading

why was it rolled back:((?
upd: not released yet. will be soon

@MystiPanda
Copy link
Copy Markdown

MystiPanda commented Jun 22, 2024 •
edited
Loading

I just tested the latest version, but it seems that the changes did not take effect. The dmg I packaged looks like this:

image

"dmg": {
        "background": "images/background.png",
        "appPosition": {
          "x": 180,
          "y": 170
        },
        "applicationFolderPosition": {
          "x": 480,
          "y": 170
        },
        "windowSize": {
          "height": 400,
          "width": 660
        },
        "windowPosition": {
          "x": 200,
          "y": 180
        }
      }

I noticed that the default position for two icon in the original code were set like this, and it didn't work in previous versions either. I'm not sure where the issue lies.

@FabianLars
Copy link
Copy Markdown
Member

FabianLars commented Jun 24, 2024

(I assume you used the CLI from git because it's not released yet?)

Did you build the dmg in CI like GitHub actions? If so then this is a known issue and happened before this PR too. :/

@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees

@FabianLars FabianLars

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hjmallon @Lurrobert @MystiPanda @FabianLars @Andreybest @lucasfernog