Skip to content

chore: remove unused import muda::AboutMetadataBuilder#8294

Merged
amrbashir merged 1 commit intotauri-apps:devfrom
deid84:dev
Nov 23, 2023
Merged

chore: remove unused import muda::AboutMetadataBuilder#8294
amrbashir merged 1 commit intotauri-apps:devfrom
deid84:dev

Conversation

@deid84
Copy link
Copy Markdown
Contributor

@deid84 deid84 commented Nov 23, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@deid84 deid84 requested a review from a team as a code owner November 23, 2023 12:05
@amrbashir
Copy link
Copy Markdown
Member

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@deid84
Copy link
Copy Markdown
Contributor Author

deid84 commented Nov 23, 2023

ok i think i correctly signed the commit... how to retry to make a pull request?

@amrbashir
Copy link
Copy Markdown
Member

thank you, it is good to go now

@amrbashir amrbashir changed the title remove unused import muda::AboutMetadataBuilder chore: remove unused import muda::AboutMetadataBuilder Nov 23, 2023
@amrbashir amrbashir merged commit ad8836b into tauri-apps:dev Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants