Skip to content

refactor(tauri-utils)!: remove windows_version and is_windows_7#8271

Merged
lucasfernog merged 3 commits intodevfrom
remove/windows-version
Nov 20, 2023
Merged

refactor(tauri-utils)!: remove windows_version and is_windows_7#8271
lucasfernog merged 3 commits intodevfrom
remove/windows-version

Conversation

@amrbashir
Copy link
Copy Markdown
Member

@amrbashir amrbashir commented Nov 20, 2023

These functions are not used anymore

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner November 20, 2023 15:23
@amrbashir
Copy link
Copy Markdown
Member Author

Only the notification plugin is using that iirc, and will migrate it to windows-version crate after this is merged

FabianLars
FabianLars previously approved these changes Nov 20, 2023
lucasfernog
lucasfernog previously approved these changes Nov 20, 2023
@lucasfernog lucasfernog dismissed stale reviews from FabianLars and themself via 139ba98 November 20, 2023 21:09
@lucasfernog lucasfernog merged commit 3b91e23 into dev Nov 20, 2023
@lucasfernog lucasfernog deleted the remove/windows-version branch November 20, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants