Skip to content

fix(cli): add support to Xcode's archive#8209

Merged
lucasfernog merged 2 commits intodevfrom
fix/ios-xcode-archive
Nov 14, 2023
Merged

fix(cli): add support to Xcode's archive#8209
lucasfernog merged 2 commits intodevfrom
fix/ios-xcode-archive

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Xcode by default is archiving for all targets, we need to remove simulator targets from it. Also cleaned up our xcode-script because of that.

@lucasfernog lucasfernog requested a review from a team as a code owner November 10, 2023 14:04
amrbashir
amrbashir previously approved these changes Nov 13, 2023
@lucasfernog lucasfernog merged commit 92b50a3 into dev Nov 14, 2023
@lucasfernog lucasfernog deleted the fix/ios-xcode-archive branch November 14, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants