fix(bundler): modify version in output file name when bundling wix#8182
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Nov 7, 2023
Merged
Conversation
lucasfernog
reviewed
Nov 6, 2023
lucasfernog
approved these changes
Nov 6, 2023
Member
|
Thank you for your contribution! We actually enforce signed commits, but I'll force merge this one to save time. Would be cool if you could set it up for next time :) |
Contributor
Author
Thanks, I'm just setting it up now! I'll sign the commit next time 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
When wix bundling a project whose current version is
0.0.0-0, the file name appears as0.0.0.0. This is not identical to other files. In addition, GitHub Action searches for0.0.0-0files, so only related msi files cannot be uploaded together.