fix: (cli) format plugin string to snake case, closes #8017#8149
Merged
lucasfernog merged 4 commits intotauri-apps:devfrom Nov 8, 2023
Merged
fix: (cli) format plugin string to snake case, closes #8017#8149lucasfernog merged 4 commits intotauri-apps:devfrom
lucasfernog merged 4 commits intotauri-apps:devfrom
Conversation
amrbashir
requested changes
Nov 6, 2023
Member
amrbashir
left a comment
There was a problem hiding this comment.
Thanks for your contribution, Can you also add a change file in .changes directory?
Contributor
Author
|
Done. Anything else? Should I include |
lucasfernog
reviewed
Nov 7, 2023
lucasfernog
approved these changes
Nov 7, 2023
Member
|
We actually use the heck crate to convert cases but the replace here is ok. |
Contributor
Author
Thanks for mentioning it. I should've stick to my guns. I did see |
amrbashir
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is that it?