Skip to content

refactor: Optimize Simplified Chinese language content#8137

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
ShoreCN:refactor/nsis-language-chinese
Nov 6, 2023
Merged

refactor: Optimize Simplified Chinese language content#8137
lucasfernog merged 2 commits intotauri-apps:devfrom
ShoreCN:refactor/nsis-language-chinese

Conversation

@ShoreCN
Copy link
Copy Markdown
Contributor

@ShoreCN ShoreCN commented Oct 30, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Optimize Simplified Chinese language content

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@ShoreCN ShoreCN requested a review from a team as a code owner October 30, 2023 07:43
Copy link
Copy Markdown
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

(I'm not sure how we handle PRs like these now that 1.x was merged into dev so i'll leave it to the others to merge it)

@lucasfernog
Copy link
Copy Markdown
Member

Just to be clear this PR targets v2 ok? To make this change on v1 it needs to target the 1.x branch.

@lucasfernog
Copy link
Copy Markdown
Member

Thank you for the PR! ❤️

@lucasfernog lucasfernog merged commit fd532da into tauri-apps:dev Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants