refactor(core): break manager struct into smaller ones#8124
Merged
lucasfernog merged 12 commits intodevfrom Nov 7, 2023
Merged
refactor(core): break manager struct into smaller ones#8124lucasfernog merged 12 commits intodevfrom
lucasfernog merged 12 commits intodevfrom
Conversation
amrbashir
requested changes
Oct 30, 2023
Member
There was a problem hiding this comment.
I think my main problem with this PR is the excessive usage of Arc, do you think we can somehow remove the need for it?
Edit: the Arc usage was excessive before as well, I guess I misspoke, what I mean, can we reduce the Arc usage now that we have grouped multiple fields together?
Member
Author
|
@amrbashir I've done my best with the Arc removals, some are still around because there's some types that are cloned and moved to another thread / closure (mostly callbacks). |
amrbashir
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information