Skip to content

fix(cross): Fix docker image and cross setup#8094

Merged
lucasfernog merged 1 commit intotauri-apps:devfrom
olivierlemasle:fix-cross-job
Oct 26, 2023
Merged

fix(cross): Fix docker image and cross setup#8094
lucasfernog merged 1 commit intotauri-apps:devfrom
olivierlemasle:fix-cross-job

Conversation

@olivierlemasle
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

- Updating to Ubuntu 22.04
  libwebkit2gtk-4.1-dev is not available for Ubuntu 18.04
- Adding a WORKSPACE_VOLUME to fix issue `failed to find a workspace root`
  Cf. cross-rs/cross#1181
@olivierlemasle olivierlemasle requested a review from a team as a code owner October 24, 2023 21:33
Copy link
Copy Markdown
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@lucasfernog lucasfernog merged commit 6bc3b05 into tauri-apps:dev Oct 26, 2023
@olivierlemasle olivierlemasle deleted the fix-cross-job branch October 26, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants