Skip to content

feat(macOS): Add AppHandle::show() and AppHandle::hide()#2825

Closed
probablykasper wants to merge 12 commits intotauri-apps:devfrom
probablykasper:mac-app-hide
Closed

feat(macOS): Add AppHandle::show() and AppHandle::hide()#2825
probablykasper wants to merge 12 commits intotauri-apps:devfrom
probablykasper:mac-app-hide

Conversation

@probablykasper
Copy link
Copy Markdown
Member

@probablykasper probablykasper commented Oct 30, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Exposes macOS-only show_application and hide_application from tao.

@probablykasper probablykasper requested a review from a team as a code owner October 30, 2021 04:03
@probablykasper probablykasper requested review from a team October 30, 2021 04:03
amrbashir
amrbashir reviewed Dec 6, 2021
View reviewed changes
Comment thread .changes/mac-app-hide.md Outdated
@probablykasper probablykasper changed the title feat(macOS): Add AppHandle::hide() feat(macOS): Add AppHandle::show() and AppHandle::hide() Dec 7, 2021
@probablykasper
Copy link
Copy Markdown
Member Author

probablykasper commented Dec 7, 2021

@amrbashir Any idea why the build-artifacts action is failing, or how to go about fixing it? The EventLoopWindowTargetExtMacOS trait is imported, and app_handle.show() does work when I run tauri dev.

error[E0599]: no method named `show_application` found for reference `&EventLoopWindowTarget<Message>` in the current scope
    --> /Users/runner/work/tauri/tauri/core/tauri-runtime-wry/src/lib.rs:1952:20
     |
1952 |         event_loop.show_application();
     |                    ^^^^^^^^^^^^^^^^ method not found in `&EventLoopWindowTarget<Message>`

@amrbashir
Copy link
Copy Markdown
Member

amrbashir commented Dec 7, 2021

don't know really, but I think the updater-test-artifacts workflow has been broken for a while. @lucasfernog might have a better idea.

@probablykasper
Copy link
Copy Markdown
Member Author

probablykasper commented Dec 28, 2021

@amrbashir @lucasfernog either of you wanna give this one a look so it can be merged?

@lucasfernog
Copy link
Copy Markdown
Member

lucasfernog commented Dec 28, 2021

@amrbashir @lucasfernog either of you wanna give this one a look so it can be merged?

I think this one will need to wait for v2.

@amrbashir amrbashir added the scope: core Core packages of Tauri label Jan 1, 2022
@probablykasper probablykasper mentioned this pull request Jan 10, 2022
Open
@probablykasper probablykasper requested review from a team February 13, 2022 00:06
@probablykasper probablykasper changed the base branch from next to dev February 13, 2022 00:32
@probablykasper probablykasper mentioned this pull request Mar 12, 2022
Merged
13 tasks
@probablykasper
Copy link
Copy Markdown
Member Author

probablykasper commented Mar 12, 2022

Opened PR #3689 instead, from a different branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir left review comments

Assignees

No one assigned

Labels

scope: core Core packages of Tauri

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@probablykasper @amrbashir @lucasfernog