Skip to content

feat: add cursor_position#668

Merged
amrbashir merged 6 commits intodevfrom
feat/cursor-position
Jan 12, 2023
Merged

feat: add cursor_position#668
amrbashir merged 6 commits intodevfrom
feat/cursor-position

Conversation

@amrbashir
Copy link
Copy Markdown
Member

@amrbashir amrbashir commented Jan 10, 2023 •
edited by wusyong
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

TODOs:

  • test and confirm macOS

@amrbashir amrbashir requested a review from a team as a code owner January 10, 2023 00:24
wusyong
wusyong reviewed Jan 11, 2023
View reviewed changes
Comment thread src/platform_impl/linux/util.rs Outdated
wusyong
wusyong reviewed Jan 11, 2023
View reviewed changes
Comment thread src/platform_impl/ios/event_loop.rs
wusyong
wusyong reviewed Jan 11, 2023
View reviewed changes
Comment thread src/platform_impl/android/mod.rs
wusyong
wusyong reviewed Jan 11, 2023
View reviewed changes
Comment thread src/platform_impl/android/mod.rs
@wusyong wusyong self-requested a review January 11, 2023 13:40
@wusyong
Copy link
Copy Markdown
Member

wusyong commented Jan 12, 2023

macOS is working btw.

@amrbashir amrbashir merged commit 5d8bf51 into dev Jan 12, 2023
@amrbashir amrbashir deleted the feat/cursor-position branch January 12, 2023 13:09
@github-actions github-actions Bot mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wusyong wusyong wusyong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add monitor::cursor_position()

2 participants

@amrbashir @wusyong