feat: add set_dock_visibility method#1058
Merged
lucasfernog merged 8 commits intotauri-apps:devfrom Mar 7, 2025
Merged
Conversation
Contributor
Package Changes Through aca837cThere are 1 changes which include tao with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Signed-off-by: The1111mp <The1111mp@outlook.com>
Signed-off-by: The1111mp <The1111mp@outlook.com>
lucasfernog
reviewed
Mar 7, 2025
Member
yeah that's a dev-only thing we'll need to fix on the tauri side later |
lucasfernog
approved these changes
Mar 7, 2025
Member
lucasfernog
left a comment
There was a problem hiding this comment.
pretty good - let's wait and see if we need to port any of the electron patches
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
set_dock_visibilitymethod to support setting the visibility of the application in the dock.Close #105
As mentioned here, refer to
Electronto implementset_dock_visibilitymethod.This is my first PR, so there are some issues that need further confirmation:
set_dock_visibilityneed to be completely consistent withset_activation_policy. For example, we don’t need to do anything extra here: https://github.com/1111mp/tao/blob/c4d0f0555fb0f65993fa4f7b944c45465ed14211/src/platform_impl/macos/app_delegate.rs#L32dockerare consistent with the behavior ofElectron. More extensive testing may be needed...This is my local demo:

Should the icon change only occur in the local environment? I pointed tauri and tao directly to the local code by
patch.crates-ioand then started the demo project.Demo code: