-
Notifications
You must be signed in to change notification settings - Fork 508
Description
open from shell plugin can't open file if the file is being used by a program on Windows, for example, the log file from the log plugin
We're currently using open to handle open files in shell plugin, and this is a bug in that crate
plugins-workspace/plugins/shell/src/scope.rs
Line 211 in 9d4b25c
Some(program) => ::open::with_detached(path, program),
I have discussed with the author of open on Byron/open-rs#90 and we both think maybe it's better to use opener (this crate is used by rustup by the way) for this case
But this crate doesn't support open with specific program, so maybe if we still want to support that, we can use opener for handling default open, and open for open with specific program
Another added benefit is that we can add reveal from opener, as it's a highly requested feature #999
Opens the default file explorer and reveals a file or folder in its containing folder.