Skip to content

feat(ui): Close auth window on 3rd-party login flow#8359

Merged
lotas merged 1 commit intomainfrom
feat/8357-login-extra-window
Mar 9, 2026
Merged

feat(ui): Close auth window on 3rd-party login flow#8359
lotas merged 1 commit intomainfrom
feat/8357-login-extra-window

Conversation

@lotas
Copy link
Contributor

@lotas lotas commented Mar 9, 2026

Extra window that was opened on 3rd party login was not closing, leaving extra taskcluster homepage

Fixes: #8357

@lotas lotas requested a review from a team as a code owner March 9, 2026 09:19
@lotas lotas requested review from matt-boris and petemoore and removed request for a team March 9, 2026 09:19
export const AUTH_STARTED = '@@TASKCLUSTER_AUTH_STARTED';
// The delay (in milliseconds) for `setTimeout` is a 32 bit signed quantity,
// which limits it to 2^31-1 ms (2147483647 ms) or 24.855 days.
export const MAX_SET_TIMEOUT_DELAY = 2 ** 31 - 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not used anymore

@lotas lotas merged commit 5042dd1 into main Mar 9, 2026
73 checks passed
@lotas lotas deleted the feat/8357-login-extra-window branch March 9, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TC OAuth third-party flow opens dashboard tab in opener window — breaks popup-based auth flows

2 participants