Skip to content

fix(generic-worker): stay alive at idle timeout if wm says to#8327

Merged
matt-boris merged 3 commits intomainfrom
matt-boris/gwCheckWithWmBeforeIdleTimeout
Mar 2, 2026
Merged

fix(generic-worker): stay alive at idle timeout if wm says to#8327
matt-boris merged 3 commits intomainfrom
matt-boris/gwCheckWithWmBeforeIdleTimeout

Conversation

@matt-boris
Copy link
Contributor

@matt-boris matt-boris commented Feb 27, 2026

Fixes #8326.

Generic Worker: when running with worker-runner, the worker now checks with Worker Manager before shutting down due to idle timeout. If Worker Manager says the worker is still needed (e.g., to satisfy minCapacity), the idle timer resets instead of shutting down. Workers not running with worker-runner are unaffected.

@matt-boris matt-boris requested a review from a team as a code owner February 27, 2026 17:15
@matt-boris matt-boris requested review from lotas and petemoore and removed request for a team February 27, 2026 17:15
@matt-boris matt-boris force-pushed the matt-boris/gwCheckWithWmBeforeIdleTimeout branch 2 times, most recently from 3296a47 to 99525c8 Compare February 27, 2026 17:33
@matt-boris matt-boris mentioned this pull request Feb 27, 2026
Closed
@matt-boris matt-boris enabled auto-merge February 27, 2026 19:52
@matt-boris matt-boris force-pushed the matt-boris/gwCheckWithWmBeforeIdleTimeout branch from 99525c8 to 17e38f2 Compare February 27, 2026 20:38
petemoore
petemoore reviewed Mar 2, 2026
View reviewed changes
@matt-boris matt-boris force-pushed the matt-boris/gwCheckWithWmBeforeIdleTimeout branch from 17e38f2 to aa66301 Compare March 2, 2026 11:17
@matt-boris matt-boris disabled auto-merge March 2, 2026 11:27
@matt-boris matt-boris force-pushed the matt-boris/gwCheckWithWmBeforeIdleTimeout branch 2 times, most recently from c96344b to 0b76412 Compare March 2, 2026 14:28
@matt-boris matt-boris force-pushed the matt-boris/gwCheckWithWmBeforeIdleTimeout branch from 0b76412 to 3d2f5d4 Compare March 2, 2026 14:37
lotas
lotas approved these changes Mar 2, 2026
View reviewed changes
Copy link
Contributor

@lotas lotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 👍

@matt-boris matt-boris merged commit d8ff1bf into main Mar 2, 2026
73 checks passed
@matt-boris matt-boris deleted the matt-boris/gwCheckWithWmBeforeIdleTimeout branch March 2, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petemoore petemoore petemoore left review comments

@lotas lotas lotas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generic Worker does not check with Worker Manager before shutting down due to idle timeout

3 participants

@matt-boris @lotas @petemoore