feat(queue): Fix pagination issues with big task groups#8324
Merged
Conversation
What happened is that some very large Task Groups would return duplicate overlapping tasks in listTaskGroup response with pagination, while hiding some other tasks from the response. Fixes #8323
ab95b09 to
224fa9c
Compare
matt-boris
reviewed
Feb 27, 2026
| version: 122 | ||
| description: Fix listTaskGroup pagination stability by adding ORDER BY task_id | ||
| methods: | ||
| get_tasks_by_task_group_projid: |
Contributor
There was a problem hiding this comment.
Is this fine to do? Overwrite the current db method? I thought typically we just add some incremented counter suffix?
Contributor
Author
There was a problem hiding this comment.
yes, we change the name when signature changes - either arguments change or resulting table. Here everything stays the same, just the ORDER is added, so we didn't change the signature, just the internals :) No clients would suffer from this change
matt-boris
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened is that some very large Task Groups would return duplicate overlapping tasks in listTaskGroup response with pagination, while hiding some other tasks from the response.
Fixes #8323