Skip to content

fix(generic-worker): clean temp livelog streaming files#8320

Merged
matt-boris merged 1 commit intomainfrom
matt-boris/cleanupLivelogFiles
Feb 26, 2026
Merged

fix(generic-worker): clean temp livelog streaming files#8320
matt-boris merged 1 commit intomainfrom
matt-boris/cleanupLivelogFiles

Conversation

@matt-boris
Copy link
Contributor

Fixes #7652.

Generic Worker & Livelog: fix livelog temporary streaming files not being cleaned up. The livelog process creates a temp directory per stream, but since the generic worker kills it with SIGKILL, the process never has a chance to clean up. Fixed by having the generic worker create a dedicated temp directory for each livelog process (via the new LIVELOG_TEMP_DIR env var) and removing it after the process is killed.

@matt-boris matt-boris requested a review from a team as a code owner February 26, 2026 16:49
@matt-boris matt-boris requested review from lotas and petemoore and removed request for a team February 26, 2026 16:49
@@ -0,0 +1,5 @@
audience: worker-deployers
level: minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this minor and not patch due to the new LIVELOG_TEMP_DIR env var that can be used when running livelog.

@matt-boris matt-boris enabled auto-merge February 26, 2026 16:53
@matt-boris matt-boris merged commit 97015b5 into main Feb 26, 2026
73 checks passed
@matt-boris matt-boris deleted the matt-boris/cleanupLivelogFiles branch February 26, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Livelog doesn't clean up temp streaming files properly

2 participants