Skip to content

Conversation

@jwhitlock
Copy link
Contributor

Update from Go 1.16.7 to 1.17.6. This is a major update which adds a new build constraints format. Details:

  • Added a developer document for how to upgrade Go and Node.js
  • Ran go fmt on the files, generating the new build constraint comment
  • Manually removed the old build constraints comment
  • Updated the go generator to output the new format
  • Build and push new CI docker images

Github Bug/Issue: Fixes #5082

This was previously part of PR #5084, and incorporates feedback from reviews.

@jwhitlock jwhitlock requested a review from petemoore January 26, 2022 17:06
@jwhitlock jwhitlock requested a review from a team as a code owner January 26, 2022 17:06
@jwhitlock jwhitlock requested a review from lotas January 26, 2022 17:06
@jwhitlock
Copy link
Contributor Author

Rebased on main, force pushed.

The commit "Check for uin32 size with ParseUnit" was suggested by a linter. When I went to run tests on the generic worker with ./build.sh -t, a few go updates were applied to go.mod. I did not include these updates, but we may want to update the generic worker as well.

There's one more linter issue that I wanted @petemoore's feedback on before merging.

@petemoore
Copy link
Member

Rebased on main, force pushed.

The commit "Check for uin32 size with ParseUnit" was suggested by a linter. When I went to run tests on the generic worker with ./build.sh -t, a few go updates were applied to go.mod. I did not include these updates, but we may want to update the generic worker as well.

There's one more linter issue that I wanted @petemoore's feedback on before merging.

So looking at the warnings, they appear to be when strings are logged that are partly composed from data read in from the generic-worker config file. For example, in the generic-worker config file, the taskcluster root url property is set with the rootURL config setting. URLs are logged in the worker logs, that derive from this URL. Headers are also potentially logged, which will a one-time Authorization header, only valid for that particular request (so safe to log). But internally, it is signed by the access token, which originates from the user-provided generic-worker config file (where user in this since is the administrator that installed and configured the worker).

So I don't think any of these warnings are of particular concern, since a real user or task has no write access to the config file, and therefore cannot adjust values. If they could modify this file, we would have a much bigger problem, I believe.

This fixes an issue where the generic worker failed to build on M1 MacBooks (arm64).
Added notes for updating go and node.
@jwhitlock jwhitlock merged commit 3c15c00 into main Jan 27, 2022
@jwhitlock jwhitlock deleted the go-1.17-5082 branch January 27, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yarn generate broken on M1 Macbooks (arm64), go 1.16.7

4 participants