feat(hooks): add ability to specify 'taskId' when triggering hooks#8287
feat(hooks): add ability to specify 'taskId' when triggering hooks#8287matt-boris merged 1 commit intotaskcluster:mainfrom
Conversation
34f765f to
5b9c48d
Compare
5b9c48d to
bb3c913
Compare
matt-boris
left a comment
There was a problem hiding this comment.
Changes LGTM, thank you for implementing!
Noted the breaking client changes, just requesting the changelog be updated please 🙏🏻
bb3c913 to
cf05752
Compare
|
|
||
| try { | ||
| resp = await this.taskcreator.fire(hook, context); | ||
| resp = await this.taskcreator.fire(hook, context, options); |
There was a problem hiding this comment.
I realized that if I extracted the taskId here, then we wouldn't need to rely on hook authors to set it in the JSON-e template..
But if this crosses some sort of boundary, we could instead extract it from the rendered task definition.
|
I started having some difficulty spinning up a local instance (getting "no matching manifest for linux/amd64 in the manifest list entries" errors on |
Which containers are you getting this for? I've run into this as well, and have |
|
I just filed: Let's move discussion there |
cf05752 to
f0e733c
Compare
|
I managed to validate this on a local instance by downgrading to tc-admin 4.0.0. Please merge for me when you're ready :) |
No description provided.