Skip to content

Do not save data with _pytest.outcomes.Exit#119

Merged
tarpas merged 3 commits into
tarpas:masterfrom
blueyed:exit
Jan 21, 2019
Merged

Do not save data with _pytest.outcomes.Exit#119
tarpas merged 3 commits into
tarpas:masterfrom
blueyed:exit

Conversation

@blueyed

@blueyed blueyed commented Dec 14, 2018

Copy link
Copy Markdown
Contributor

This was changed in pytest (will be in 4.1).

Exit is derived from SystemExit and not KeyboardInterrupt anymore.

Ref pytest-dev/pytest#4292

This was changed in pytest (will be in 4.1).

`Exit` is derived from `SystemExit` and not `KeyboardInterrupt` anymore.

Ref pytest-dev/pytest#4292
@tarpas

tarpas commented Jan 18, 2019

Copy link
Copy Markdown
Owner

@blueyed Daniel, at a quick glance I don't understand why the build is failing here or how to fix it.

@blueyed

blueyed commented Jan 18, 2019

Copy link
Copy Markdown
Contributor Author

pytest-xdist does not support the pytest version: https://travis-ci.org/tarpas/pytest-testmon/jobs/468087696#L488

I am changing it to use py36-pytest41-xdist instead.

@tarpas tarpas merged commit aa4d3ef into tarpas:master Jan 21, 2019
@blueyed blueyed deleted the exit branch January 21, 2019 19:58
@blueyed

blueyed commented Jan 21, 2019

Copy link
Copy Markdown
Contributor Author

Sorry, this will be changed likely in pytest-dev/pytest#4280 again.

It should not handle SystemExit, but pytest's Exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants