Skip to content

Look at TESTMON_DATAFILE to configure datafile location#100

Merged
tarpas merged 1 commit into
tarpas:masterfrom
blueyed:TESTMON_DATAFILE
Jun 30, 2018
Merged

Look at TESTMON_DATAFILE to configure datafile location#100
tarpas merged 1 commit into
tarpas:masterfrom
blueyed:TESTMON_DATAFILE

Conversation

@blueyed

@blueyed blueyed commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

I am looking into adding a "testmon" factor to pytest's tox.ini, but
noticed that this should be kept per tox environment.

Therefore the tox.ini could specify:

setenv =
    testmon: TESTMON_DATAFILE={envdir}/.testmondata

There are likely other use cases where this would come in handy.

What do you think?

TODO:

  • doc

[ci skip]

I am looking into adding a "testmon" factor to pytest's tox.ini, but
noticed that this should be kept per tox environment.

Therefore the `tox.ini` could specify:

```ini
setenv =
    testmon: TESTMON_DATAFILE={envdir}/.testmondata
```

There are likely other use cases where this would come in handy.

What do you think?

TODO:

- [ ] doc
@blueyed

blueyed commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

I have created tox-dev/tox#847 to have e.g. TOX_ENVDIR in the environment, which would make up for a good intermediate fallback (i.e. pytest's tox.ini would not have to define TESTMON_DATAFILE explicitly).

@blueyed

blueyed commented Jun 30, 2018

Copy link
Copy Markdown
Contributor Author

@tarpas
What is your opinion on this?

I am currently looking into creating a tox plugin that would/could be shipped with testmon itself, and would adjust the default location for .testmondata then to be inside of tox's current venv.
This plugin could simply set this environment variable then.

@tarpas tarpas merged commit 2565c6c into tarpas:master Jun 30, 2018
@tarpas

tarpas commented Jun 30, 2018

Copy link
Copy Markdown
Owner

Thanks for explanation and for the code, I think it's fine.

@blueyed blueyed deleted the TESTMON_DATAFILE branch July 1, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants