-
Notifications
You must be signed in to change notification settings - Fork 18
olly latency does not compute latency correctly #7
Copy link
Copy link
Closed
Description
For a minor GC immediately followed by a major slice on OCaml 5.0, the current probes for runtime events emit events like this
olly computes the latency by computing the duration of the non-enclosed span. In the trace above, the spans stw_leader (corresponding to the minor gc) and major (corresponding to the major slice) are both non-enclosed. While the real GC latency is the sum of the span duration for stw_leader and major, olly currently identifies them as separate events. Hence, the latencies reported by olly latency will be lower than the real latencies.
Fix
This can be fixed either by
- Ensuring that for any GC event, there is a single outermost non-enclosed span. This needs change in how the events are emitted in the OCaml runtime.
- Apply heuristics to identify that these two events correspond to a single compound GC event where the mutator does not get a chance to run between.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
