Skip to content

misc: cleanup usage of pthread_cancel#9690

Merged
locker merged 1 commit intotarantool:masterfrom
nshy:pthread-cancel-cleanup
Feb 21, 2024
Merged

misc: cleanup usage of pthread_cancel#9690
locker merged 1 commit intotarantool:masterfrom
nshy:pthread-cancel-cleanup

Conversation

@nshy
Copy link
Contributor

@nshy nshy commented Feb 14, 2024

At last we can drop usage of pthread_cancel and associated functions. And remove related leak suppressions.

Close #8423

@nshy nshy requested a review from a team as a code owner February 14, 2024 10:49
@nshy nshy added do not merge Not ready to be merged asan-ci Enables asan build tests for a pull request labels Feb 14, 2024
@nshy nshy force-pushed the pthread-cancel-cleanup branch from be8cb7b to b5a53a0 Compare February 14, 2024 10:55
@coveralls
Copy link

coveralls commented Feb 14, 2024

Coverage Status

coverage: 86.953% (+0.01%) from 86.943%
when pulling 741520d on nshy:pthread-cancel-cleanup
into a83d5e3
on tarantool:master
.

@nshy nshy force-pushed the pthread-cancel-cleanup branch 2 times, most recently from 50f569e to 41011ca Compare February 15, 2024 11:10
At last we can drop usage of pthread_cancel and associated functions.
And remove related leak suppressions.

Let's keep memory protection disabling under ASAN. Otherwise
leak sanitizer may misbehave on Tarantool panic as below.

```
  #   Tracer caught signal 11: addr=0x705236d1e000 pc=0x57b7605b10d0 sp=0x705232a00ca0\
  #   ==1022907==LeakSanitizer has encountered a fatal error.\
  #   ==1022907==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1\
  #   ==1022907==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)",
```

Let's also add missing pipe/endpoint destroy in wal while at it.

Close tarantool#8423

NO_CHANGELOG=internal
NO_DOC=internal
@nshy nshy force-pushed the pthread-cancel-cleanup branch from 41011ca to 741520d Compare February 21, 2024 09:50
@nshy nshy removed the do not merge Not ready to be merged label Feb 21, 2024
@nshy nshy requested a review from locker February 21, 2024 11:17
@locker locker assigned nshy and unassigned locker Feb 21, 2024
@nshy nshy added the full-ci Enables all tests for a pull request label Feb 21, 2024
@nshy nshy assigned locker and unassigned nshy Feb 21, 2024
@locker locker merged commit 0e86fbd into tarantool:master Feb 21, 2024
@nshy nshy deleted the pthread-cancel-cleanup branch February 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asan-ci Enables asan build tests for a pull request full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of pthread_cancel()

4 participants