box: cover box_wait limbo_acked#9234
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Nov 2, 2023
Merged
Conversation
ochaplashkin
approved these changes
Oct 9, 2023
sergepetrenko
requested changes
Oct 10, 2023
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Good job on the patch!
Please find my comments below.
sergepetrenko
requested changes
Oct 11, 2023
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Some more comments from me
9dccafa to
61282db
Compare
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for the fixes!
Looks nice. I only have a couple comments left.
sergepetrenko
approved these changes
Oct 25, 2023
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Good job! LGTM.
Next time please attach a diff in a comment when changes are minor. It's much easier to re-check the patch this way.
Gerold103
reviewed
Oct 25, 2023
Collaborator
Gerold103
left a comment
There was a problem hiding this comment.
Thanks for the patch!
7f91ab2 to
5da8500
Compare
Astronomax
commented
Oct 26, 2023
648f490 to
8791d15
Compare
a2525d9 to
96ddd91
Compare
Prior to this patch, there were many possible code execution options that were not covered by tests. After this commit, any assert(false) inside box_wait_limbo_acked cause a crash. Closes tarantool#7318 NO_DOC=test NO_CHANGELOG=test
Gerold103
approved these changes
Nov 1, 2023
Collaborator
Gerold103
left a comment
There was a problem hiding this comment.
Thanks for the fixes!
ylobankov
approved these changes
Nov 1, 2023
Collaborator
box_wait limbo_acked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, there were many possible code execution options
that were not covered by tests. After this commit, any assert(false)
inside box_wait_limbo_acked cause a crash.
Closes #7318
NO_DOC=test
NO_CHANGELOG=test