Skip to content

third_party: update libcurl from 7.87.0 to 8.3.0#9133

Merged
kyukhin merged 1 commit intotarantool:masterfrom
ligurio:ligurio/gh-9086-bump-curl
Sep 14, 2023
Merged

third_party: update libcurl from 7.87.0 to 8.3.0#9133
kyukhin merged 1 commit intotarantool:masterfrom
ligurio:ligurio/gh-9086-bump-curl

Conversation

@ligurio
Copy link
Member

@ligurio ligurio commented Sep 13, 2023

The patch updates curl module to the version 8.3.0 [1] and updates a CMake module for building curl library.

Changes in CMake module:

  • Option CURL_STATICLIB is gone and replaced with BUILD_STATIC_LIBS.
  • Option CURL_USE_GNUTLS was added and disabled by default.
  • NSS library support was removed and option CURL_USE_NSS has been removed as well.
  • Option CMAKE_UNITY_BUILD was added and disabled by default.
  • Option CURL_DISABLE_FORM_API was added and disabled by default. It is in fact depends on CURL_DISABLE_MIME, but anyway disabled explicitly.

Changelog: https://curl.se/changes.html#8_3_0

  1. https://github.com/curl/curl/releases/tag/curl-8_3_0

NO_DOC=libcurl submodule bump
NO_TEST=libcurl submodule bump

Fixes #9086
Follows up tarantool/etcd-client#62

@ligurio ligurio requested a review from a team as a code owner September 13, 2023 07:53
@ligurio ligurio force-pushed the ligurio/gh-9086-bump-curl branch from 66d05ed to 7d710df Compare September 13, 2023 08:01
@coveralls
Copy link

coveralls commented Sep 13, 2023

Coverage Status

coverage: 86.413% (-0.001%) from 86.414% when pulling 1d2aaf7 on ligurio:ligurio/gh-9086-bump-curl into abefe2c
on tarantool:master
.

@ligurio ligurio requested a review from Totktonada September 13, 2023 08:13
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side. Thank you!

The patch updates curl module to the version 8.3.0 [1] and updates a
CMake module for building curl library.

Changes in CMake module:

- Option `CURL_STATICLIB` is gone and replaced with `BUILD_STATIC_LIBS`.
- Option `CURL_USE_GNUTLS` was added and disabled by default.
- NSS library support was removed and option `CURL_USE_NSS` has been
  removed as well.
- Option `CMAKE_UNITY_BUILD` was added and disabled by default.
- Option `CURL_DISABLE_FORM_API` was added and disabled by default. It is
  in fact depends on `CURL_DISABLE_MIME`, but anyway disabled explicitly.

Changelog: https://curl.se/changes.html#8_3_0

1. https://github.com/curl/curl/releases/tag/curl-8_3_0

NO_DOC=libcurl submodule bump
NO_TEST=libcurl submodule bump

Fixes tarantool#9086
@ligurio ligurio force-pushed the ligurio/gh-9086-bump-curl branch from 7d710df to 1d2aaf7 Compare September 13, 2023 13:57
@ligurio ligurio added the full-ci Enables all tests for a pull request label Sep 13, 2023
@kyukhin kyukhin enabled auto-merge (rebase) September 14, 2023 06:15
@kyukhin kyukhin merged commit 979b4ad into tarantool:master Sep 14, 2023
@ligurio ligurio deleted the ligurio/gh-9086-bump-curl branch September 14, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http.client does not finish current streams after a connection lost

5 participants