Skip to content

memtx: fix logic of read tracker rebinding during rollback#7836

Merged
alyapunov merged 1 commit intotarantool:masterfrom
CuriousGeorgiy:gh-7828-rollback-read-tracker-rebind-wrong-idx-mask
Nov 30, 2022
Merged

memtx: fix logic of read tracker rebinding during rollback#7836
alyapunov merged 1 commit intotarantool:masterfrom
CuriousGeorgiy:gh-7828-rollback-read-tracker-rebind-wrong-idx-mask

Conversation

@CuriousGeorgiy
Copy link
Member

@CuriousGeorgiy CuriousGeorgiy commented Oct 23, 2022

During rollback read trackers are rebound to newer or older story, if
present. The problem with the current logic is that read trackers are
basically rebound in the first available index: all information about key
parts read from other indexes gets lost — rebind read trackers in all
indexes.

Closes #7828

NO_DOC=bugfix

@coveralls
Copy link

coveralls commented Oct 23, 2022

Coverage Status

Coverage increased (+0.06%) to 85.177% when pulling 0d8ff0a on CuriousGeorgiy:gh-7828-rollback-read-tracker-rebind-wrong-idx-mask into a1ba58d
on tarantool:master
.

@CuriousGeorgiy CuriousGeorgiy force-pushed the gh-7828-rollback-read-tracker-rebind-wrong-idx-mask branch 3 times, most recently from f30e678 to 6b5bcb1 Compare October 28, 2022 11:44
Copy link
Contributor

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit only

@drewdzzz drewdzzz added the do not merge Not ready to be merged label Oct 31, 2022
@drewdzzz drewdzzz assigned CuriousGeorgiy and unassigned drewdzzz Oct 31, 2022
@CuriousGeorgiy CuriousGeorgiy changed the title memtx: fix wrong index mask in rebound read tracker during rollback memtx: fix logic of read tracker rebinding during rollback Oct 31, 2022
@CuriousGeorgiy CuriousGeorgiy removed their assignment Oct 31, 2022
During rollback read trackers are rebound to newer or older story, if
present. The problem with the current logic is that read trackers are
basically rebound in the first available index: all information about key
parts read from other indexes gets lost — rebind read trackers in all
indexes.

Closes tarantool#7828

NO_DOC=bugfix
@CuriousGeorgiy CuriousGeorgiy force-pushed the gh-7828-rollback-read-tracker-rebind-wrong-idx-mask branch from 6b5bcb1 to 0d8ff0a Compare November 9, 2022 14:50
@CuriousGeorgiy CuriousGeorgiy removed the do not merge Not ready to be merged label Nov 9, 2022
@alyapunov alyapunov added the full-ci Enables all tests for a pull request label Nov 29, 2022
@alyapunov alyapunov merged commit 559b27d into tarantool:master Nov 30, 2022
@alyapunov
Copy link
Contributor

Backported to 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phantom read after gets from different indexes

4 participants