memtx: split memtx_tx_story_unlink_both logic in two separate contexts#7758
Merged
alyapunov merged 1 commit intotarantool:masterfrom Nov 9, 2022
Merged
Conversation
a342e8a to
f40768a
Compare
f40768a to
3e8e1d8
Compare
drewdzzz
requested changes
Oct 3, 2022
3e8e1d8 to
44a2020
Compare
drewdzzz
approved these changes
Oct 12, 2022
`memtx_tx_story_unlink_both` is called in two separate contexts: on space delete and on rollback. In the former case we need to simply unlink the story, while in the latter case we need to rebind read and gap trackers, and, perhaps do some other logic in the future. Calling `memtx_tx_story_unlink_both` in the former context can trigger assertion: split the function and its helpers into two separate functions for each case, grouping the common logic into third `*_common` functions. Closes tarantool#7757 NO_DOC=bugfix
44a2020 to
0f74945
Compare
alyapunov
approved these changes
Nov 8, 2022
Contributor
|
Cherry-picked to 2.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memtx_tx_story_unlink_bothis called in two separate contexts: on space delete and on rollback. In the former case we need to simply unlink the story, while in the latter case we need to rebind read and gap trackers, and, perhaps do some other logic in the future. Callingmemtx_tx_story_unlink_bothin the former context can trigger assertion: split the function and its helpers into two separate functions for each case, grouping the common logic into third*_commonfunctions.Closes #7757