memtx: fix HASH index 'GT' iterator next method set incorrectly#7488
Merged
alyapunov merged 1 commit intotarantool:masterfrom Aug 4, 2022
Merged
Conversation
affea67 to
c8af8e9
Compare
The `next` method of memtx HASH index 'GT' iterator is initially set to 'GT' and is supposed to be set to 'GE' after first iteration: it is mistakenly set to the 'base' method instead of the full method which also does tuple clarification — this allows dirty reads. Move the `next` method change on first iteration to `WRAP_ITERATOR_METHOD` for clarity and correctness. Closes tarantool#7477 NO_DOC=bugfix
c8af8e9 to
162923b
Compare
alyapunov
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nextmethod of memtx HASH index 'GT' iterator is initially set to'GT' and is supposed to be set to 'GE' after first iteration: it is
mistakenly set to the 'base' method instead of the full method which also
does tuple clarification — this allows dirty reads. Move the
nextmethodchange on first iteration to
WRAP_ITERATOR_METHODfor clarity andcorrectness.
Closes #7477