memtx: fix tree iterator next result clarification#7444
Merged
alyapunov merged 1 commit intotarantool:masterfrom Aug 5, 2022
Merged
Conversation
f8428bd to
7577eac
Compare
7577eac to
a1f21c3
Compare
Member
Author
|
@drewdzzz what variable? |
Contributor
|
tarantool/src/box/memtx_tree.cc Lines 547 to 548 in 969b76a It is used only for tree_iterator_set_current_tuple(it, *ret); after this patch, but commit from another PR removes it.
|
Member
Author
|
@drewdzzz don't worry, build will fail anyways: /Users/georgiy.lebedev/Work/tarantool/src/box/memtx_tree.cc:609:1: error: unused variable 'it' [-Werror,-Wunused-variable]
WRAP_ITERATOR_METHOD(tree_iterator_next_equal_raw);
^
/Users/georgiy.lebedev/Work/tarantool/src/box/memtx_tree.cc:596:34: note: expanded from macro 'WRAP_ITERATOR_METHOD'
struct tree_iterator<USE_HINT> *it = \
|
The problem is described in tarantool#7073. It was fixed only for `tree_iterator_start_raw` next method, but other methods used for reverse iterators are also subject to this bug: move tuple clarification from the wrapper of iterator `next` methods to individual iterator methods. Closes tarantool#7432 NO_DOC=bugfix
a1f21c3 to
d11fc0e
Compare
alyapunov
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is described in #7073. It was fixed only for
tree_iterator_start_rawnext method, but other methods used for reverseiterators are also subject to this bug: move tuple clarification from the
wrapper of iterator
nextmethods to individual iterator methods.Closes #7432