memtx: fix handling of corner cases gap tracking in transaction manager#7395
Merged
alyapunov merged 2 commits intotarantool:masterfrom Aug 5, 2022
Merged
Conversation
5a49c94 to
4bc1a13
Compare
4bc1a13 to
098aeab
Compare
Korablev77
reviewed
Jul 13, 2022
| ((dir < 0 && cmp > 0) || | ||
| (cmp > 0 && item->type == ITER_EQ) || | ||
| (cmp == 0 && ((dir < 0 && is_full_key) || | ||
| item->type == ITER_LT))); |
Contributor
There was a problem hiding this comment.
This seems to be impossible to understand without any explanations :(
Member
Author
There was a problem hiding this comment.
Neither did the existing code... Do you have any ideas on how to make it clear what's going on?
Korablev77
approved these changes
Jul 13, 2022
098aeab to
4063d01
Compare
drewdzzz
requested changes
Jul 29, 2022
4063d01 to
6b1d227
Compare
drewdzzz
previously requested changes
Jul 29, 2022
6b1d227 to
d6a5cf4
Compare
Since `ITER_ALL` is an alias to `ITER_GE` in context of TREE index, denormalize it during iterator creation. Needed for tarantool#7375 NO_CHANGELOG=refactoring NO_DOC=refactoring NO_TEST=refactoring
Gap tracking does not handle gap writes when the key has the same value as the gap item: review the whole gap write handling logic, refactor it and fix handling of corner cases along the way. Co-authored-by: Alexander Lyapunov <alyapunov@tarantool.org> Closes tarantool#7375 NO_DOC=bugfix
d6a5cf4 to
9592619
Compare
alyapunov
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap tracking does not handle gap writes when the key has the same value as
the gap item: review the whole gap write handling process, refactor it and
fix handling of corner cases along the way.
Closes #7375