mvcc: fix reverse tree iterators gap tracking#7077
Merged
alyapunov merged 1 commit intotarantool:masterfrom May 19, 2022
Merged
mvcc: fix reverse tree iterators gap tracking#7077alyapunov merged 1 commit intotarantool:masterfrom
alyapunov merged 1 commit intotarantool:masterfrom
Conversation
alyapunov
reviewed
May 4, 2022
Contributor
alyapunov
left a comment
There was a problem hiding this comment.
Waiting for test, and I should recheck that the code is correct in all cases..
91f25bb to
4c52bb2
Compare
drewdzzz
requested changes
May 12, 2022
4c52bb2 to
57302fd
Compare
alyapunov
suggested changes
May 18, 2022
drewdzzz
reviewed
May 18, 2022
Contributor
drewdzzz
left a comment
There was a problem hiding this comment.
That's OK, but the code will change after you fix the other reviewer's remarks. Then request the review again, please.
Apparently, the current implementation of `tree_iterator_start_raw` is buggy for reverse iterators: instead of tracking gaps for successors of keys, it tracks gaps for tuples shifted by one to the left of the successor: reorder the code of `tree_iterator_start_raw` to get the successor tuple prior to shifting done for reverse iterators and simplify the implementation to make it more straightforward and thus comprehensible. Closes tarantool#7073 Closes tarantool#7113 NO_DOC=bugfix Co-authored-by: Alexander Lyapunov <alyapunov@tarantool.org>
57302fd to
9fd389a
Compare
drewdzzz
approved these changes
May 19, 2022
alyapunov
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, the current implementation of
tree_iterator_start_rawisbuggy for reverse iterators: instead of tracking gaps for successors of
keys, it tracks gaps for tuples shifted by one to the left of the
successor: reorder the code of
tree_iterator_start_rawto getthe successor tuple prior to shifting done for reverse iterators and
simplify the implementation to make it more straightforward and thus
comprehensible.
Closes #7073
Closes #7113